Pin browser-language cards on the dashboard#180
Conversation
Agent-Logs-Url: https://github.com/python-docs-translations/dashboard/sessions/bce329f5-881d-4092-b19d-a7bed12a8937 Co-authored-by: m-aciek <9288014+m-aciek@users.noreply.github.com>
Agent-Logs-Url: https://github.com/python-docs-translations/dashboard/sessions/bce329f5-881d-4092-b19d-a7bed12a8937 Co-authored-by: m-aciek <9288014+m-aciek@users.noreply.github.com>
Agent-Logs-Url: https://github.com/python-docs-translations/dashboard/sessions/9303e6ae-44fe-4547-9351-f81ab0cd622f Co-authored-by: m-aciek <9288014+m-aciek@users.noreply.github.com>
StanFromIreland
left a comment
StanFromIreland
left a comment
There was a problem hiding this comment.
-1 on this without a way to also optionally sort them by % completion/alphabetically. While this may be more convenient for some it will also not allow them to view the dashboard how it currently displays languages.
I think engaging people to contribute is a higher priority purpose than providing a dry information. By bringing the user language(s) to front it is harder to miss them, on a page that already force you to scroll to see through all languages (we have now 25 of them). In my opinion moving one or two languages in front is a small disruption to the order. To satisfy use case of "universal" view we could add an opt-out toggle to "unpin" users language(s). Would a thumbtack icon as first on right in top navbar be understandable/discoverable? We could/should make it disabled (grayed out) if none of user's languages is listed on the dashboard. |
Something like this would be good. But, maybe have the thumbtack in the corner of the cards? |
Agent-Logs-Url: https://github.com/python-docs-translations/dashboard/sessions/b832ebdb-d3dc-40ec-a886-66ba818048a0 Co-authored-by: m-aciek <9288014+m-aciek@users.noreply.github.com>
Agent-Logs-Url: https://github.com/python-docs-translations/dashboard/sessions/b832ebdb-d3dc-40ec-a886-66ba818048a0 Co-authored-by: m-aciek <9288014+m-aciek@users.noreply.github.com>
|
@copilot resolve the merge conflicts in this pull request |
…t-to-index # Conflicts: # .gitignore # templates/index.html.jinja
Resolved in
All linters pass after auto-applying the djLint formatting change (space before |
m-aciek
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03112a7863
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
I played around with it, but I feel pinning the entire set is a little odd compared to just the first entry: 
IMO, this feels like something that should be limited to the preferred language. It preserves the dashboard’s completion-based order with minimal disruption. If I got several pinned cards I'd be confused as a user. |
Summary
Add client-side pinning for cards that match the visitor's browser languages so they appear first by default without losing access to the original dashboard order.
Changes
navigator.languagesand move them to the front on loadlocalStorageValidation
pre-commit run --all-filespython -m unittest discover -s tests(fails only in external link-check cases because several hosts do not resolve in the sandbox:python-docs-es.readthedocs.io,www.flowdas.com,git.afpy.org,python.org.br)📊 Dashboard preview 📊: https://python-docs-translations.github.io/dashboard/180/merge/